Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add range error validation for datatypes #1594

Merged
merged 7 commits into from
Jan 31, 2024

Merge branch 'michael-DatatypeRangeCheck' of https://github.com/tedio…

8598f04
Select commit
Loading
Failed to load commit list.
Merged

feat: add range error validation for datatypes #1594

Merge branch 'michael-DatatypeRangeCheck' of https://github.com/tedio…
8598f04
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 31, 2024 in 1s

66.05% (-12.19%) compared to 6a961b5

View this Pull Request on Codecov

66.05% (-12.19%) compared to 6a961b5

Details

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (6a961b5) 78.24% compared to head (8598f04) 66.05%.

Files Patch % Lines
src/data-types/date.ts 42.85% 2 Missing and 2 partials ⚠️
src/data-types/datetime.ts 42.85% 2 Missing and 2 partials ⚠️
src/data-types/datetime2.ts 42.85% 2 Missing and 2 partials ⚠️
src/data-types/datetimeoffset.ts 42.85% 2 Missing and 2 partials ⚠️
src/data-types/smalldatetime.ts 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #1594       +/-   ##
===========================================
- Coverage   78.24%   66.05%   -12.19%     
===========================================
  Files          93       93               
  Lines        4821     4858       +37     
  Branches      921      932       +11     
===========================================
- Hits         3772     3209      -563     
- Misses        750     1245      +495     
- Partials      299      404      +105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov