Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a directive for disabling inheritance #170

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Implement a directive for disabling inheritance #170

merged 1 commit into from
Jun 8, 2022

Conversation

psss
Copy link
Collaborator

@psss psss commented Jun 8, 2022

As the first step for the special fmf directives let's allow to
completely disable inheriting data from parent which is currently
the most desired use case.

Fix #14.

@psss psss added this to the 1.1 milestone Jun 8, 2022
@psss psss added the base label Jun 8, 2022
@psss psss requested review from happz, jscotka, lukaszachy and thrix June 8, 2022 12:11
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@happz happz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #171 to address the reinvention of the validation process. Other than this, LGTM.

As the first step for the special `fmf` directives let's allow to
completely disable inheriting data from parent which is currently
the most desired use case.

Fix #14.
@psss psss self-assigned this Jun 8, 2022
@psss
Copy link
Collaborator Author

psss commented Jun 8, 2022

Thanks to all for your quick reviews. Squashed & ready to merge once tests are green.

@psss psss merged commit ed4d296 into main Jun 8, 2022
@psss psss deleted the psss-inherit branch June 8, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define a way how to undefine an attribute
4 participants