Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP621 and hatch scripts #202

Merged
merged 12 commits into from
Nov 29, 2024
Merged

PEP621 and hatch scripts #202

merged 12 commits into from
Nov 29, 2024

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Aug 9, 2023

Here are various modernizaitons to the pyproject

  • Switched to PEP621
  • Switched to src-layout structure. Dropped as people are opposed to it
  • Changed the build backend to hatchling
  • Added some hatch environments and scripts to align with tmt a bit
  • Switched the bin/fmf file to a script entry-point
  • Functional change: Switched to dynamic version
  • Simplified the spec file
  • Removed .travis.yaml Small cleanups #237
  • python-coveralls dependency was removed. Not sure where that one was used
  • Switch PyPI publishing to trusted-publishing. This eliminates the use of the secret token. Closes Missing sdist in PyPI #224

@lukaszachy
Copy link
Collaborator

We need to be able to build on epel-9 which fails now (very likely contains too old macros/utils).

@psss WHat about epel-8 though, can we stop providing updates as we did with tmt? epel-8 has even older macros ;)

@lukaszachy
Copy link
Collaborator

Makefile contains useful stuff as 'make (s)rpm', 'make clean'. IMO we need leave it (it can call hatch commands though).

@lukaszachy
Copy link
Collaborator

Switched to src-layout structure.

We moved AWAY from it in the past. Easier to use libraries locally when python path works out of the box.

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Aug 9, 2023

We need to be able to build on epel-9 which fails now (very likely contains too old macros/utils).

Indeed, I was just about to look into that. I was debugging locally and I hit an issue with it just now about dynamic version. It's weird that the same setup is used in packit. That needs a bit of debugging.

Makefile contains useful stuff as 'make (s)rpm', 'make clean'. IMO we need leave it (it can call hatch commands though).

Sure thing. I would still prefer the CI, packit and spec to use the direct commands though. Fine with that?

We moved AWAY from it in the past. Easier to use libraries locally when python path works out of the box.

Roger. It is a dev preference in the end

@LecrisUT LecrisUT force-pushed the pep621 branch 3 times, most recently from 059f6d9 to 4d79f9c Compare August 9, 2023 18:21
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Aug 9, 2023

I am not sure why Rhel9 build is failing. I can't seem to debug it to check if the tmp folder includes .git_archival.txt. Any ideas on how to debug that?

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Aug 9, 2023

Seems like the error message in the JsonSchemaValidator is different on the other distros:

[31mFailed to load step data for DiscoverFmfStepData: Field 'DiscoverFmfStepData:ref' must be a string, 'int' found.�[0m
:: [ 18:35:04 ] :: [   FAIL   ] :: File '/var/tmp/rlRun_LOG.VEO4lNoT' should contain 'Failed to load step data for DiscoverFmfStepData: Field 'DiscoverFmfStepData:ref' must be unset or a string, 'int' found.' 

(note the lack of must be unset or...

And similar with tmt errors reported.

@psss
Copy link
Collaborator

psss commented Aug 10, 2023

@psss What about epel-8 though, can we stop providing updates as we did with tmt? epel-8 has even older macros ;)

Yes, I'd say we should keep fmf and tmt aligned, let's stop providing updates for el-8.

@LecrisUT
Copy link
Contributor Author

Ok, this should be ok for this PR. @psss can someone look into the testing-farm failures? They are in the integration test and it should just need a more relaxed check of the fail message.

@psss
Copy link
Collaborator

psss commented Aug 10, 2023

@psss can someone look into the testing-farm failures? They are in the integration test and it should just need a more relaxed check of the fail message.

The testing farm failures were most probably caused by the fresh tmt not being in the stable repo. Should be good now.

@psss
Copy link
Collaborator

psss commented Aug 10, 2023

/packit test

@LecrisUT LecrisUT mentioned this pull request Aug 10, 2023
@LecrisUT LecrisUT force-pushed the pep621 branch 3 times, most recently from 8ccf9b6 to 8ca3f85 Compare August 11, 2023 09:41
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Aug 11, 2023

@lukaszachy , @psss Ok, with this Epel 9 is fixed. Thanks to Nikola from packit for debugging the issue. I've also expanded the github tests, can someone trigger them? I've also enabled codecov, but on my project it did not work without a secret token. Maybe that needs to be setup here as well?

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Aug 11, 2023

/packit test

@LecrisUT
Copy link
Contributor Author

@lukaszachy, @psss, @happz Review for this one please?

@psss
Copy link
Collaborator

psss commented Sep 19, 2023

@psss What about epel-8 though, can we stop providing updates as we did with tmt? epel-8 has even older macros ;)

Yes, I'd say we should keep fmf and tmt aligned, let's stop providing updates for el-8.

Filed #212 to drop support for el8.

@psss
Copy link
Collaborator

psss commented Sep 19, 2023

@lukaszachy, @psss, @happz Review for this one please?

Sorry, had a bunch of stuff on the plate so I did no get to this. Will have a look, hopefully this week. Sorry for the delay.

@psss psss added this to the 1.4 milestone Sep 29, 2023
@psss
Copy link
Collaborator

psss commented Sep 29, 2023

Let's finish this as one of the first things for the 1.4 release.

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Sep 29, 2023

Oh, I need to rebase (after #215), need anything else than that?

@psss
Copy link
Collaborator

psss commented Oct 2, 2023

Yes, please rebase. No other changes needed right now (at least from the quick look through the changes).

@chenrui333
Copy link

any luck with this PR?

pyproject.toml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link

@seberm seberm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, thanks!

Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing this! Looks good to me, just two minor things.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@psss
Copy link
Collaborator

psss commented Nov 28, 2024

/packit build

@psss
Copy link
Collaborator

psss commented Nov 28, 2024

@martinhoyer, could you please review as well?

@martinhoyer
Copy link
Contributor

test.pypi looks good: https://test.pypi.org/project/fmf/

@psss psss added the packaging label Nov 29, 2024
@psss psss merged commit 94c2616 into teemtee:main Nov 29, 2024
11 checks passed
@LecrisUT LecrisUT deleted the pep621 branch January 8, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing sdist in PyPI
6 participants