-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP621 and hatch
scripts
#202
Conversation
We need to be able to build on epel-9 which fails now (very likely contains too old macros/utils). @psss WHat about epel-8 though, can we stop providing updates as we did with tmt? epel-8 has even older macros ;) |
Makefile contains useful stuff as 'make (s)rpm', 'make clean'. IMO we need leave it (it can call hatch commands though). |
We moved AWAY from it in the past. Easier to use libraries locally when python path works out of the box. |
Indeed, I was just about to look into that. I was debugging locally and I hit an issue with it just now about dynamic version. It's weird that the same setup is used in packit. That needs a bit of debugging.
Sure thing. I would still prefer the CI, packit and spec to use the direct commands though. Fine with that?
Roger. It is a dev preference in the end |
059f6d9
to
4d79f9c
Compare
I am not sure why Rhel9 build is failing. I can't seem to debug it to check if the tmp folder includes |
Seems like the error message in the JsonSchemaValidator is different on the other distros:
(note the lack of And similar with tmt errors reported. |
Yes, I'd say we should keep |
Ok, this should be ok for this PR. @psss can someone look into the testing-farm failures? They are in the integration test and it should just need a more relaxed check of the fail message. |
The testing farm failures were most probably caused by the fresh |
/packit test |
8ccf9b6
to
8ca3f85
Compare
@lukaszachy , @psss Ok, with this Epel 9 is fixed. Thanks to Nikola from packit for debugging the issue. I've also expanded the github tests, can someone trigger them? I've also enabled codecov, but on my project it did not work without a secret token. Maybe that needs to be setup here as well? |
/packit test |
@lukaszachy, @psss, @happz Review for this one please? |
Sorry, had a bunch of stuff on the plate so I did no get to this. Will have a look, hopefully this week. Sorry for the delay. |
Let's finish this as one of the first things for the |
Oh, I need to rebase (after #215), need anything else than that? |
Yes, please rebase. No other changes needed right now (at least from the quick look through the changes). |
any luck with this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM, thanks!
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing this! Looks good to me, just two minor things.
/packit build |
@martinhoyer, could you please review as well? |
test.pypi looks good: https://test.pypi.org/project/fmf/ |
Here are various modernizaitons to the pyproject
Switched toDropped as people are opposed to itsrc-layout
structure.bin/fmf
file to a script entry-pointRemovedSmall cleanups #237.travis.yaml
python-coveralls
dependency was removed. Not sure where that one was usedsdist
in PyPI #224