Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support virtualization.is-supported hw requirement for mrack #2954

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented May 22, 2024

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@happz happz added status | blocked The merging of PR is blocked on some other issue area | hardware Implementation of hardware requirements plugin | mrack The beaker provision plugin labels May 22, 2024
@happz
Copy link
Collaborator

happz commented May 22, 2024

Adding blocked because the filter would work for x86_64 only, other arches would fail horribly. Maybe we should start thinking about using a config file, because the better filter we're using with Artemis downstream is 1. quite bigger than a single element, and 2. might reveal information that must remain internal. So, something that can be provided without being public would be way better.

@skycastlelily
Copy link
Collaborator Author

skycastlelily commented May 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | hardware Implementation of hardware requirements plugin | mrack The beaker provision plugin status | blocked The merging of PR is blocked on some other issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants