Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default unit of memory to MiB if non is provided #3113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set default unit of memory to MiB if non is provided #3113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/hardware/memory.fmf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: |
.. code-block::

# Number or string, the amount of memory requested.
# Bytes are assumed when no unit is specified.
# MiB is assumed when no unit is specified.
memory: 1234|"2 GiB"

example:
Expand Down
3 changes: 2 additions & 1 deletion tmt/hardware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1307,7 +1307,8 @@ def _parse_memory(spec: Spec) -> BaseConstraint:
'memory',
str(spec['memory']),
allowed_operators=[
Operator.EQ, Operator.NEQ, Operator.LT, Operator.LTE, Operator.GT, Operator.GTE])
Operator.EQ, Operator.NEQ, Operator.LT, Operator.LTE, Operator.GT, Operator.GTE],
default_unit='MiB')


def _parse_hostname(spec: Spec) -> BaseConstraint:
Expand Down
Loading