Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto variables in tangential trace #70

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Conversation

jdoelz
Copy link
Collaborator

@jdoelz jdoelz commented Jul 4, 2023

No description provided.

@jdoelz jdoelz requested a review from mx-nlte July 4, 2023 15:15
@jdoelz jdoelz closed this Jul 4, 2023
@jdoelz
Copy link
Collaborator Author

jdoelz commented Jul 4, 2023

This is actually the first commit of a tangential trace...

@jdoelz jdoelz reopened this Jul 4, 2023
Copy link
Member

@mx-nlte mx-nlte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll write a unit test. One idea is build the linear form with a vector valued function (e.g. [x, y, z]) and check if the tangential components are integrated correctly.

@mx-nlte mx-nlte self-assigned this Jul 14, 2023
@mx-nlte mx-nlte self-requested a review February 13, 2024 12:09
@mx-nlte mx-nlte self-requested a review February 13, 2024 12:11
@mx-nlte mx-nlte merged commit 0237739 into master Feb 13, 2024
6 checks passed
@mx-nlte mx-nlte deleted the TangentialTrace branch February 13, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants