Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract ComputeEnclosingBall and Add Helper Function Guideline #99

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

mx-nlte
Copy link
Member

@mx-nlte mx-nlte commented Sep 25, 2024

Fixes #98

@mx-nlte mx-nlte requested a review from jdoelz September 25, 2024 11:42
@mx-nlte
Copy link
Member Author

mx-nlte commented Sep 25, 2024

The function computeEnclosingBall does not use any functionality of the ElementTree and might be used at any place in the code.

Copy link
Collaborator

@jdoelz jdoelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@mx-nlte mx-nlte merged commit 82e998a into temf:master Sep 30, 2024
3 checks passed
@mx-nlte mx-nlte deleted the extract-compute_enclosing_ball branch September 30, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link in README to Coding Guidelines Misses
2 participants