Refactor deployment templates to support additional env vars from Secret #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bles from secrets
robholland
reviewed
Nov 5, 2024
robholland
requested changes
Nov 6, 2024
Co-authored-by: Rob Holland <[email protected]>
Co-authored-by: Rob Holland <[email protected]>
Co-authored-by: Rob Holland <[email protected]>
robholland
approved these changes
Nov 7, 2024
asproul
pushed a commit
to asproul/helm-charts
that referenced
this pull request
Dec 16, 2024
…ret (temporalio#603) * Refactor deployment templates to support additional environment variables from secrets * Add documentation --------- Co-authored-by: Rob Holland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added option to pass secret name which will be mouted as env variables in the contianer.
Why?
This will help in scenarios like SSO integration or other conifgurations.
Checklist
Closes
[Feature Request] Use a Kubernetes secret to protect the OIDC client secret #236
How was this tested:
Using helm render locally.
Any docs updates needed?
Added
Enable SSO in Temporal UIsection in README.md