Fix DB filename argument for ephemeral server #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
turnage
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This is a relatively simple fix: the ephemeral server code isn't using the correct option name for setting the SQLite filename argument.
Why?
I didn't check old versions of the ephemeral server, but I am at least confident that for
temporal version 1.0.0 (Server 1.24.2, UI 2.28.0), the current flag is incorrect.Checklist
Closes
How was this tested:
Ran the updated SDK against our internal codebase and validated that the flag worked. I can add a regression test if y'all like, but wasn't sure if it was worth it here.
Any docs updates needed?