Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust MaxBufferedQueryCount #1829

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Adjust MaxBufferedQueryCount #1829

merged 1 commit into from
Aug 1, 2023

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Jul 31, 2023 •
edited
Loading

@Quinn-With-Two-Ns Quinn-With-Two-Ns changed the title Lower intensity of test Adjust MaxBufferedQueryCount Jul 31, 2023
@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review July 31, 2023 19:30
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner July 31, 2023 19:30
@Quinn-With-Two-Ns
Copy link
Contributor Author

This change is needed because of this server change temporalio/temporal@2830f38 to intentionally make exceeding the max query buffer a non retry able error. The other options would be to lower the intensity of the test or add retries in the test. Since the purpose of the test is to stress the SDK with lots of queries while running local activities I think increasing the server limit stresses the SDK the most

@cretz
Copy link
Member

cretz commented Aug 1, 2023

I think increasing the server limit stresses the SDK the most

Concur. A bit strange to stress the SDK in CI like this, but meh.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 3ffe294 into temporalio:master Aug 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz