Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace interpolated variables #1833

Closed
wants to merge 2 commits into from
Closed

Replace interpolated variables #1833

wants to merge 2 commits into from

Conversation

jackdawm
Copy link
Contributor

@jackdawm jackdawm commented Aug 4, 2023 •
edited
Loading

What was changed

Set a different variable to the interpolated inputs, and enclose them in quotes.

Why?

This is to prevent bash injections in our runners.

Checklist

How was this tested:
Ran this workflow on my fork and read the logs, I did get 403ed at the "Create release" step.

@jackdawm jackdawm marked this pull request as ready for review August 4, 2023 19:31
@jackdawm jackdawm requested a review from a team as a code owner August 4, 2023 19:31
@jackdawm jackdawm closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackdawm @Quinn-With-Two-Ns