Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add WorkflowImplementationOptions customizer #1835

Merged
merged 3 commits into from
Aug 19, 2023
Merged

add WorkflowImplementationOptions customizer #1835

merged 3 commits into from
Aug 19, 2023

Conversation

antmendoza
Copy link
Member

What was changed

Allow set WorkflowImplementationOptions using customizer
https://github.com/temporalio/sdk-java/tree/master/temporal-spring-boot-autoconfigure-alpha#customization-of-options

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@antmendoza antmendoza requested a review from a team as a code owner August 5, 2023 10:54
Quinn-With-Two-Ns
Quinn-With-Two-Ns reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, was OOTO and then traveling.

LGTM, you have some CI error could you address them? then I will approve.

@antmendoza
Copy link
Member Author

@Quinn-With-Two-Ns I think it is done now, sorry I didn't notice it failed

@Quinn-With-Two-Ns Quinn-With-Two-Ns enabled auto-merge (squash) August 16, 2023 16:56
@antmendoza
Copy link
Member Author

@Quinn-With-Two-Ns ^^ :)

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit c012357 into temporalio:master Aug 19, 2023
4 checks passed
@Quinn-With-Two-Ns
Copy link
Contributor

@antmendoza Sorry about that thought I approved when I enabled auto-merge.

@antmendoza
Copy link
Member Author

no problem, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antmendoza @Quinn-With-Two-Ns