-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build test server on ubuntu 18 #1836
Build test server on ubuntu 18 #1836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't mind the YAML cleanup. Let's wait for @mjameswh or @Quinn-With-Two-Ns to approve.
The proto submodule got inadvertently updated here, may want to put it back |
Looks like build is broken @mjameswh @Quinn-With-Two-Ns
|
ab99491
to
b3ccbde
Compare
Looks like I accidentally updated the submodule, build should fix itself. |
You have to also push tags to your fork/branch. It's a known Java contributor annoyance atm. |
LGTM, yeah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use
buildjet-2vcpu-ubuntu-1804
to build the test server.GitHub deprecated the 18.04 runners, which we need to support older versions of glibc.
My editor automatically ran prettier on the yaml file, I can revert that if reviewer has an issue.