Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build test server on ubuntu 18 #1836

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

bergundy
Copy link
Member

@bergundy bergundy commented Aug 7, 2023

Use buildjet-2vcpu-ubuntu-1804 to build the test server.
GitHub deprecated the 18.04 runners, which we need to support older versions of glibc.

My editor automatically ran prettier on the yaml file, I can revert that if reviewer has an issue.

@bergundy bergundy requested a review from a team as a code owner August 7, 2023 16:06
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't mind the YAML cleanup. Let's wait for @mjameswh or @Quinn-With-Two-Ns to approve.

@cretz
Copy link
Member

cretz commented Aug 7, 2023

The proto submodule got inadvertently updated here, may want to put it back

@bergundy
Copy link
Member Author

bergundy commented Aug 7, 2023

Looks like build is broken @mjameswh @Quinn-With-Two-Ns



> Task :temporal-serviceclient:compileJava
--
  | /temporal-java-client/temporal-serviceclient/src/main/java/io/temporal/serviceclient/LongPollUtil.java:33: error: cannot find symbol
  | \|\| method == WorkflowServiceGrpc.getUpdateWorkflowExecutionMethod()
  | ^
  | symbol:   method getUpdateWorkflowExecutionMethod()
  | location: class WorkflowServiceGrpc
  | /temporal-java-client/temporal-serviceclient/src/main/java/io/temporal/serviceclient/LongPollUtil.java:34: error: cannot find symbol
  | \|\| method == WorkflowServiceGrpc.getPollWorkflowExecutionUpdateMethod()) {
  | ^
  | symbol:   method getPollWorkflowExecutionUpdateMethod()
  | location: class WorkflowServiceGrpc


@bergundy bergundy force-pushed the test-server-build-ubuntu-18 branch from ab99491 to b3ccbde Compare August 7, 2023 16:51
@bergundy
Copy link
Member Author

bergundy commented Aug 7, 2023

Looks like I accidentally updated the submodule, build should fix itself.

@cretz
Copy link
Member

cretz commented Aug 7, 2023

You have to also push tags to your fork/branch. It's a known Java contributor annoyance atm.

@Quinn-With-Two-Ns
Copy link
Contributor

LGTM, yeah features requires your git branch to have tags for Java

Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bergundy bergundy merged commit 622edc0 into temporalio:master Aug 14, 2023
4 checks passed
@bergundy bergundy deleted the test-server-build-ubuntu-18 branch August 14, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants