Reconcile typed search attributes with schedules #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * <p>This should only be used when the server can return untyped search attributes, for example, | ||
| * when describing a schedule workflow action. | ||
| */ | ||
| public static SearchAttributeKey<Payload> forUntyped(String name) { |
There was a problem hiding this comment.
We could also make calling valueSet and valueUnset an error since I am not aware of any valid use case
There was a problem hiding this comment.
Yeah, that would work, I think we should. We can hide this more in other langs. Arguably we could make the name of this method more unwieldy, but this is probably good.
cretz
approved these changes
Aug 24, 2023
| * <p>This should only be used when the server can return untyped search attributes, for example, | ||
| * when describing a schedule workflow action. | ||
| */ | ||
| public static SearchAttributeKey<Payload> forUntyped(String name) { |
There was a problem hiding this comment.
Yeah, that would work, I think we should. We can hide this more in other langs. Arguably we could make the name of this method more unwieldy, but this is probably good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typed search attributes in java schedules by:
ScheduleOptionsSearchAttributesdo not work when creating a scheduleSearchAttributescontainer through a special key typecloses #1847