Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeout of canRunWithResourceBasedTuner #2313

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Increase timeout of canRunWithResourceBasedTuner #2313

merged 1 commit into from
Nov 13, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Nov 8, 2024 •
edited
Loading

Increase timeout of canRunWithResourceBasedTuner to try to fix flakes like seen here https://github.com/temporalio/sdk-java/actions/runs/11802877846/job/32883424690

@Quinn-With-Two-Ns Quinn-With-Two-Ns changed the title Add timeout to canRunWithResourceBasedTuner Increase timeout to canRunWithResourceBasedTuner Nov 12, 2024
@Quinn-With-Two-Ns Quinn-With-Two-Ns changed the title Increase timeout to canRunWithResourceBasedTuner Increase timeout of canRunWithResourceBasedTuner Nov 12, 2024
@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review November 12, 2024 23:37
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner November 12, 2024 23:37
cretz
cretz approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrmm, so that test before failed after 10s but the same test in this CI run succeeded after only 3s. My guess is that whatever caused the 10s hang will cause a 5m hang too, but no harm in trying I suppose.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 02ff5cd into temporalio:master Nov 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz