Sorting version summaries in DescribeWorkerDeployment calls #7398
+65
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlydf
reviewed
Feb 28, 2025
tests/worker_deployment_test.go
Outdated
|
|
||
| // waiting for 3 seconds to start the second version later. | ||
| startTime := time.Now() | ||
| waitTime := 3 * time.Second |
There was a problem hiding this comment.
can you make waitTime 1 ms instead? that will be enough that we can still tell sorting, without adding too much time to the total test time
tests/worker_deployment_test.go
Outdated
|
|
||
| // waiting for 1 second to start the next version later. | ||
| startTime := time.Now() | ||
| waitTime := 1 * time.Second |
There was a problem hiding this comment.
same here, I think waitTime can just be 1ms without adding flakiness
carlydf
reviewed
Feb 28, 2025
tests/worker_deployment_test.go
Outdated
| @@ -264,6 +264,15 @@ func (s *WorkerDeploymentSuite) TestDescribeWorkerDeployment_TwoVersions() { | |||
| secondVersion := tv.WithBuildIDNumber(2) | |||
|
|
|||
| go s.pollFromDeployment(ctx, firstVersion) | |||
|
|
|||
| // waiting for 3 seconds to start the second version later. | |||
There was a problem hiding this comment.
Suggested change
| // waiting for 3 seconds to start the second version later. | |
| // waiting for 1 millisecond to start the second version later. |
carlydf
reviewed
Feb 28, 2025
tests/worker_deployment_test.go
Outdated
| for i := 0; i < numVersions; i++ { | ||
| go s.pollFromDeployment(ctx, tv.WithBuildIDNumber(i)) | ||
|
|
||
| // waiting for 1 second to start the next version later. |
There was a problem hiding this comment.
Suggested change
| // waiting for 1 second to start the next version later. | |
| // waiting for 1 millisecond to start the next version later. |
carlydf
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?