Fix rate limiting in priority matcher #7406
Open
+171
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
approved these changes
Mar 1, 2025
| return delay <= 0 | ||
| now := time.Now().UnixNano() | ||
| d.tasks.consumeTokens(now, task, -1) | ||
| d.match() // another task may be ready to match now |
Comment on lines
+599
to
+601
| func (s *simpleLimiter) consume(now int64, tokens int64) { | ||
| s.ready = max(now, s.ready+s.burst) - s.burst + tokens*s.interval | ||
| } |
There was a problem hiding this comment.
As discussed, additional comment would be helpful to explain the overall intuition.
| ready int64 // unix nanos | ||
| } | ||
|
|
||
| func (s *simpleLimiter) set(rate float64, burst int) { |
There was a problem hiding this comment.
As discussed, passing in burst duration seems slightly easier to follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
not tested yet, on feature branch