Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHASM: Wire up noop chasm tree with mutable state #7407

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CHASM: Wire up noop chasm tree with mutable state #7407

wants to merge 1 commit into from
+912 −535

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Feb 28, 2025

What changed?

  • Wire up noop chasm tree with mutable state

Why?

  • To make sure we have the right methods on chasm tree and can work with rest of the stack.

How did you test it?

  • Unit test WIP

Potential risks

  • N/A, noop tree impl is used.

Documentation

  • N/A

Is hotfix candidate?

  • No

yycptt
yycptt commented Feb 28, 2025
View reviewed changes
Copy link
Member Author

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @xwduan
Please help review replication related changes: state retriever & applyMutation/Snapshot in mutable state. Thank you!

yycptt
yycptt commented Feb 28, 2025
View reviewed changes
service/history/replication/sync_state_retriever.go
@@ -350,21 +350,18 @@ func (s *SyncStateRetrieverImpl) getNewRunInfo(ctx context.Context, namespaceId
}, nil
}

func (s *SyncStateRetrieverImpl) getMutation(mutableState workflow.MutableState, versionedTransition *persistencespb.VersionedTransition) (*persistencespb.WorkflowMutableStateMutation, error) {
func (s *SyncStateRetrieverImpl) getMutation(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am separating the rewrite here into a separate PR as it fixes a race condition issue and also improves the performance of getMutation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin Awaiting requested review from alexshtin

@xwduan xwduan Awaiting requested review from xwduan

@lina-temporal lina-temporal Awaiting requested review from lina-temporal

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yycptt