-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
@generic-pers0n is it normal if macOS and Windows builds fail? |
Right now yes |
Windows builds fail due to packaging issues with InnoSetup(?) because it can't find a language whereas macOS builds include extra files from Tenacity's libmad. Both I have to fix. Update: Windows builds are now fixed. While they did technically "build" before, the issue was with Inno Setup packaging due to some language file not being found (or something; I don't know much about Inno Setup). |
This reverts commit 59a3ee5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Saucedacity's .desktop
file (io.github.saucedacity.Saucedacity.desktop.in
), APP_ID is used instead of APP_NAME. I believe that you should use APP_NAME instead because based on what the Exec field appears to represent, the actual binary is supposed to be executed and the binary is still named 'saucedacity' from my testing on an Arch Linux machine. I tried launching the final .desktop file after building on Arch Linux and it didn't work, so I believe this is the cause.
Other than that very small thing, everything looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Will be merging later.
Related to #21.
This MR does the following:
At the moment, I commented several parts of the metadata file, as we need to properly fill them up. We need proper screenshots to show that this is Saucedacity and not Audacity, and we need to change the rest of the metadata file to reflect the project itself.