Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change spark-tensorflow-connector dependency to be spark 3.0.0 preview #141

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Change spark-tensorflow-connector dependency to be spark 3.0.0 preview #141

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c5bb25e
init pr
WeichenXu123 Oct 9, 2019
0a6c412
fix flaky test and update pom artifact
WeichenXu123 Oct 16, 2019
77bab80
Revert "fix flaky test and update pom artifact"
WeichenXu123 Oct 17, 2019
292ce87
update pom artifact
WeichenXu123 Oct 17, 2019
2ffb7b4
update pom.xml
WeichenXu123 Nov 10, 2019
0493f82
update to spark 3.0 preview2
WeichenXu123 Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions spark/spark-tensorflow-connector/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,14 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<scala.maven.version>3.2.2</scala.maven.version>
<scala.binary.version>2.11</scala.binary.version>
<scalatest.maven.version>1.0</scalatest.maven.version>
<scala.test.version>2.2.6</scala.test.version>
<maven.compiler.version>3.0</maven.compiler.version>
<scala.maven.version>4.2.0</scala.maven.version>
<scala.version>2.12.10</scala.version>
<scala.binary.version>2.12</scala.binary.version>
<scalatest.maven.version>2.0.0</scalatest.maven.version>
<scala.test.version>3.0.8</scala.test.version>
<maven.compiler.version>3.8.0</maven.compiler.version>
<java.version>1.8</java.version>
<spark.version>2.3.1</spark.version>
<spark.version>3.0.0-SNAPSHOT</spark.version>
<yarn.api.version>2.7.3</yarn.api.version>
<junit.version>4.11</junit.version>
</properties>
Expand Down Expand Up @@ -86,7 +87,7 @@
<configuration>
<recompileMode>incremental</recompileMode>
<useZincServer>true</useZincServer>
<scalaVersion>${scala.binary.version}</scalaVersion>
<scalaVersion>${scala.version}</scalaVersion>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need specify scala version "2.12.10" instead of "2.12" here, otherwise it will cause some compatibility issue inside maven scala plugin.

<checkMultipleScalaVersions>false</checkMultipleScalaVersions>
</configuration>
</plugin>
Expand Down
2 changes: 1 addition & 1 deletion ...w-connector/src/main/scala/org/tensorflow/spark/datasources/tfrecords/DefaultSource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class DefaultSource extends DataSourceRegister
}
}

object DefaultSource {
object DefaultSource extends scala.Serializable {
WeichenXu123 marked this conversation as resolved.
Show resolved Hide resolved
// The function run on each worker.
// Writes the partition to a file and returns the number of records output.
private def writePartitionLocal(
Expand Down