Add MLIR lowering for cumsum op #1186
Merged
+29
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokkumarkannan1
requested review from
nvukobratTT,
pilkicTT and
dgolubovicTT
as code owners
ashokkumarkannan1
changed the title
|
||||||||||||||
1 similar comment
|
||||||||||||||
|
||||||||||||||
mstojkovicTT
approved these changes
Feb 6, 2025
| @@ -234,6 +236,7 @@ class MLIRGenerator | |||
| case TargetType::UInt32: | |||
| TT_ASSERT(std::get<int>(value) >= 0, "Value must be an >= 0 for conversion to uint32"); | |||
| return builder_.getUI32IntegerAttr(static_cast<uint32_t>(std::get<int>(value))); | |||
| case TargetType::Int64: return builder_.getI64IntegerAttr(static_cast<int64_t>(std::get<int>(value))); | |||
There was a problem hiding this comment.
nit: Could you please add a line break here so it starts on a new line :))
There was a problem hiding this comment.
Initialy i wrote it in a newline after the clang formating it moved to the same line.
ashokkumarkannan1
force-pushed
the
akannan/op_support_cumsum
branch
2 times, most recently
from
cfb8a21 to
3d7c81c
Compare
ashokkumarkannan1
force-pushed
the
akannan/op_support_cumsum
branch
from
3d7c81c to
3bdcb43
Compare
|
||||||||||||||
1 similar comment
|
||||||||||||||
|
||||||||||||||
1 similar comment
|
||||||||||||||
nvukobratTT
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Fix #891, Fix #503
Problem description
Add MLIR lowering for cumsum op
What's changed