Add support for mod(remainder) op #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokkumarkannan1
requested review from
nvukobratTT,
pilkicTT and
dgolubovicTT
as code owners
nvukobratTT
reviewed
Nov 18, 2024
ashokkumarkannan1
force-pushed
the
akannan/remainder_fix
branch
from
fdf042e to
12cf1f0
Compare
ashokkumarkannan1
force-pushed
the
akannan/remainder_fix
branch
from
12cf1f0 to
882b110
Compare
nvukobratTT
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517
Fixes #710
TTNN directly supports remainder op and supported in TT-mlir ttir.remainder. Since TVM doesn't have remainder op, aten::remainder is mapped to tvm's mod op and this is mapped to Remainder op in Forge