Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MeshDevice should support N-dimensional mesh shapes #17477

Open
omilyutin-tt opened this issue Feb 1, 2025 · 0 comments
Open

MeshDevice should support N-dimensional mesh shapes #17477

omilyutin-tt opened this issue Feb 1, 2025 · 0 comments
Assignees
@omilyutin-tt
Labels
P0

Comments

@omilyutin-tt
Copy link
Contributor

This is currently hardcoded to 2D, while 3D (and higher) topologies are possible.

As per offline discussion with @davorchap, it makes sense to invest in the general ND mesh shapes upfront.
@omilyutin-tt omilyutin-tt added the P0 label Feb 1, 2025
@omilyutin-tt omilyutin-tt self-assigned this Feb 1, 2025
This was referenced Feb 6, 2025
Merged
Merged
omilyutin-tt added a commit that referenced this issue Feb 7, 2025
@omilyutin-tt
#17477: Move SmallVector and ShapeBase to re-use within Metal (#17669)
b552fb8 
### Ticket
#17477

### Problem description
TT-distributed requires ND shapes in Metal. Instead of having our own,
moving `ShapeBase` and `SmallVector` into Metal.

### What's changed
* Moved `ShapeBase` and `SmallVector` into Metal. `SmallVector` really
should be part of our "stl" library, so I put it there for now. I used
`ttsl` namespace - my goal is to replace `tt::stl` as it is shorter and
easier to type, also avoids confusion if anyone attempts to use `stl::`.

### Checklist
- [x] [All post
commit](https://github.com/tenstorrent/tt-metal/actions/runs/13190528665)
- [X] New/Existing tests provide coverage for changes
@omilyutin-tt omilyutin-tt mentioned this issue Feb 7, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omilyutin-tt omilyutin-tt

Labels
P0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@omilyutin-tt