-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#17477: Move SmallVector and ShapeBase to re-use within Metal #17669
Conversation
// TODO: remove this. | ||
namespace ttnn { | ||
using tt::tt_metal::SmallVector; | ||
using ttsl::SmallVector; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd want to do any renames in follow up PRs. Pending conversation on this one.
@ayerofieiev-tt @sminakov-tt please let me know your opinion here. My plan is to subclass We can also move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SmallVector is fine to move
ShapeBase is ooookay to move
What about Shape?
No strong opinion here, but my mental model for |
Ticket
#17477
Problem description
TT-distributed requires ND shapes in Metal. Instead of having our own, moving
ShapeBase
andSmallVector
into Metal.What's changed
ShapeBase
andSmallVector
into Metal.SmallVector
really should be part of our "stl" library, so I put it there for now. I usedttsl
namespace - my goal is to replacett::stl
as it is shorter and easier to type, also avoids confusion if anyone attempts to usestl::
.Checklist