-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10226: Added or refactored BH SFPU functions #12379
Conversation
fcca81d
to
5c5275d
Compare
Since Blackhole only has SD/FD C++ tests on pipelines, can you also run this |
Also how has the |
5c5275d
to
86e72c9
Compare
Tested, pass ✅ |
No, the work will be continued in https://github.com/tenstorrent/tt-metal/tree/ncvetkovic/11816-reshuffle_rows_supportas a part of #11816 |
86e72c9
to
406cf26
Compare
406cf26
to
4ff7f1a
Compare
054cb49
to
4eadbc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should unblock some of the ops that are failing in #12349
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to request that some sample of the uses cases of the sweep tests mentioned by @rtawfik01 be added to tests/ttnn/unit_tests
We are working to enable the fast-dispatch-post-commit workflow on BH CI which should cover these cases, there is a PR up where we are disabling the current failing tests on BH (see https://github.com/tenstorrent/tt-metal/tree/mchiou/11919-enable-ttnntteager-on-bh-ci) |
4eadbc2
to
a0d89ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on conversation with @abhullar-tt it sounds like we have a parallel effort and we will get unit tests turned on eventually.
1. SFPU mask - added _int version 2. SFPU reciprocal - modified to use submodule LLKs 3. SFPU sqrt - modified to use submodule LLKs 4. SFPU trunc OP - enabled for BH
a0d89ce
to
6dd526f
Compare
Ticket
#10226
Problem description
Some functions are not added/enabled for BH.
What's changed
Within the scope of this PR, the following changes are introduced:
Checklist