Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: make dependent configs dependent #16324

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

nhuang-tt
Copy link
Member

@nhuang-tt nhuang-tt commented Dec 26, 2024

Remove the use of dispatch constants from GenerateDependentConfigs.

Ticket

N/A

Problem description

GenerateDependentConfigs should only refer to upstream or downstream static configs otherwise when you change something in the upstream static config the downstream will become incorrect without any errors. This will be needed to parameterize dispatch_constants. dispatch constants and memory map should only be used to create the Static Configs.

What's changed

Describe the approach used to solve the problem.
Summarize the changes made and its impact.

Checklist

@nhuang-tt nhuang-tt marked this pull request as ready for review December 26, 2024 19:21
Copy link
Contributor

@tt-dma tt-dma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, might be worth running TG unit tests (https://github.com/tenstorrent/tt-metal/actions/workflows/pipeline-select-galaxy.yaml) just to exercise some of these code paths (multi-cq, 4-to-4 mux etc)

@nhuang-tt
Copy link
Member Author

nhuang-tt commented Dec 29, 2024 via email

Remove the use of dispatch constants from GenerateDependentConfigs
@nhuang-tt nhuang-tt force-pushed the nhuang/dependent-configs branch from 3855b78 to 54fd33a Compare December 30, 2024 03:54
@nhuang-tt nhuang-tt merged commit 6b3b9ec into main Dec 30, 2024
197 of 200 checks passed
@nhuang-tt nhuang-tt deleted the nhuang/dependent-configs branch December 30, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants