Reserve vector in cluster function #16507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliuTT
requested review from
abhullar-tt,
pgkeller,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
tt-aho
approved these changes
Jan 7, 2025
| @@ -982,6 +982,7 @@ void Cluster::set_internal_routing_info_for_ethernet_cores(bool enable_internal_ | |||
| std::vector<chip_id_t> non_mmio_devices; | |||
| std::vector<chip_id_t> mmio_devices = target_mmio_devices; | |||
| if (mmio_devices.size() == 0) { | |||
| mmio_devices.reserve(tt::Cluster::instance().number_of_pci_devices()); | |||
There was a problem hiding this comment.
Would it be clearer to reserve by devices_grouped_by_assoc_mmio_device_.size()?
There was a problem hiding this comment.
I think this is correct. We may clean up devices_grouped_by_assoc_mmio_device_ especially for the Quanta Galaxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Missed a change in previous fix.
What's changed
Patch
Checklist