#16812: Reordering cbs in reduce_init_delta #16981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atatuzunerTT
force-pushed
the
atuzuner/cb_reorder
branch
from
5e9f771 to
086175a
Compare
atatuzunerTT
requested review from
yugaoTT,
tt-aho,
asandhupatlaTT,
bbradelTT,
razorback3,
dongjin-na,
cfjchu,
ayerofieiev-tt,
dmakoviichuk-tt,
rtawfik01,
rdjogoTT,
ttmtrajkovic,
abhullar-tt,
pgkeller,
aliuTT,
tt-dma,
tt-asaigal and
ubcheema
as code owners
asandhupatlaTT
approved these changes
Jan 23, 2025
bbradelTT
approved these changes
Jan 23, 2025
yugaoTT
approved these changes
Jan 23, 2025
rdjogoTT
approved these changes
Jan 23, 2025
tt-aho
approved these changes
Jan 27, 2025
dmakoviichuk-tt
approved these changes
Jan 29, 2025
atatuzunerTT
force-pushed
the
atuzuner/cb_reorder
branch
from
086175a to
81a72b3
Compare
williamlyTT
pushed a commit
that referenced
this pull request
Jan 30, 2025
### Ticket [Link to Github Issue](#16812) ### Problem description In all compute kernel APIs, the ordering of the circular buffer parameters are input cbs first, then output cbs. However, in the reduce_init_delta function in the reduce.h kernel, the output cb parameter comes before those of input cbs. This may cause confusion (and it has in some files) as the expected ordering is inputs first and outputs later, following all other kernel APIs. ### What's changed The parameters were reordered such that the input cbs come before the output cb. Call chains were updated accordingly. ### Checklist - [x] [Post commit CI passes](https://github.com/tenstorrent/tt-metal/actions/runs/12917899606) - [x] [Blackhole Post commit](https://github.com/tenstorrent/tt-metal/actions/runs/12917901314) (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [ ] **(For models and ops writers)** Full [new models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) tests passes - [ ] New/Existing tests provide coverage for changes
yieldthought
pushed a commit
that referenced
this pull request
Jan 31, 2025
### Ticket [Link to Github Issue](#16812) ### Problem description In all compute kernel APIs, the ordering of the circular buffer parameters are input cbs first, then output cbs. However, in the reduce_init_delta function in the reduce.h kernel, the output cb parameter comes before those of input cbs. This may cause confusion (and it has in some files) as the expected ordering is inputs first and outputs later, following all other kernel APIs. ### What's changed The parameters were reordered such that the input cbs come before the output cb. Call chains were updated accordingly. ### Checklist - [x] [Post commit CI passes](https://github.com/tenstorrent/tt-metal/actions/runs/12917899606) - [x] [Blackhole Post commit](https://github.com/tenstorrent/tt-metal/actions/runs/12917901314) (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [ ] **(For models and ops writers)** Full [new models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) tests passes - [ ] New/Existing tests provide coverage for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
In all compute kernel APIs, the ordering of the circular buffer parameters are input cbs first, then output cbs. However, in the reduce_init_delta function in the reduce.h kernel, the output cb parameter comes before those of input cbs. This may cause confusion (and it has in some files) as the expected ordering is inputs first and outputs later, following all other kernel APIs.
What's changed
The parameters were reordered such that the input cbs come before the output cb. Call chains were updated accordingly.
Checklist