Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#16469 Add sharding to vecadd example #17011

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

dchenTT
Copy link
Contributor

@dchenTT dchenTT commented Jan 23, 2025

Ticket

#16469

Problem description

A new programming example of vecadd using sharding

What's changed

This is re-check in a previously reverted PR.

  1. Provide examples for sharding type of HEIGHT, WIDTH, and BLOCK.
  2. Host create sharded buffer on L1 directly.
  3. Host write vector a and b to L1 sharded buffer, read c from L1 to host. No read and write kernel is needed. Only compute kernel.
  4. cb buffer points to L1 buffer address with global address.

Checklist

  • [ x] Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

New example to demo vecadd with sharding. Previously reverted.
@dchenTT dchenTT force-pushed the feature/vecadd_sharding_new branch from 9391bd3 to 72f19e1 Compare January 23, 2025 19:34
@dchenTT dchenTT merged commit 9b5aca6 into main Jan 23, 2025
8 checks passed
@dchenTT dchenTT deleted the feature/vecadd_sharding_new branch January 23, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants