Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#0: update test_rw_buffer #17045

Merged
merged 1 commit into from
Jan 23, 2025
Merged

#0: update test_rw_buffer #17045

merged 1 commit into from
Jan 23, 2025
+41 −9

Conversation

nhuang-tt
Copy link
Member

@nhuang-tt nhuang-tt commented Jan 23, 2025 •
edited
Loading

Ticket

N/A

Problem description

This test was failing for the incorrect reasons

What's changed

  • Fixed data validation logic. Do not check result vector if we skipped the read or write.
  • Seperate bandwidth requirement for read and write / mmio and remote chip. Bandwidth going to remote is expected to be lower.

Checklist

@nhuang-tt
#0: update test_rw_buffer
f115924 
- Seperate passing conditions for mmio and remote
- Fixed data validation logic
- Seperate bandwidth requirement for read and write
@nhuang-tt nhuang-tt merged commit b67ce7f into main Jan 23, 2025
191 checks passed
@nhuang-tt nhuang-tt deleted the nhuang/test-rw-buffer branch January 23, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhullar-tt abhullar-tt abhullar-tt approved these changes

@pgkeller pgkeller Awaiting requested review from pgkeller pgkeller is a code owner

@aliuTT aliuTT Awaiting requested review from aliuTT aliuTT is a code owner

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho is a code owner

@tt-dma tt-dma Awaiting requested review from tt-dma tt-dma is a code owner

@tt-asaigal tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal is a code owner

@ubcheema ubcheema Awaiting requested review from ubcheema ubcheema is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhuang-tt @abhullar-tt