Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks for BH cache invalidate #17047

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Minor tweaks for BH cache invalidate #17047

merged 1 commit into from
Jan 23, 2025

Conversation

pgkeller
Copy link
Contributor

Ticket

None

Problem description

No need to invalidate the cache inside a spin loop reading registers.
However, still worth keeping the invalidate after a read barrier as the cost is low and not having a barrier there leaves that to the client code which is error prone and hard to debug.

What's changed

Moved the invalidate outside the spin loops in read barrier paths

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

@pgkeller pgkeller merged commit d0c7b28 into main Jan 23, 2025
58 checks passed
@pgkeller pgkeller deleted the pkeller/bh-inv branch January 23, 2025 19:25
@tt-aho
Copy link
Contributor

tt-aho commented Jan 23, 2025

We should also update noc_async_full_barrier with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants