Map aten::remainder to tvm's mod instead of floor_mod #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvukobratTT
reviewed
Nov 18, 2024
| @@ -4622,7 +4622,7 @@ def create_convert_map(self): | |||
| "aten::floor_divide": self.make_elemwise("floor_divide"), | |||
| "aten::true_divide": self.make_elemwise("divide"), | |||
| "aten::fmod": self.make_elemwise("trunc_mod"), | |||
| "aten::remainder": self.make_elemwise("floor_mod"), | |||
There was a problem hiding this comment.
Why are we changing this from floor_mod to pure mod?
There was a problem hiding this comment.
I tested with both floor_mod and mod op and I didn't face any mismatch there. So I Will close this PR and track with floor_mod itself @nvukobratTT
|
Changes not required. aten::remainder will be tracked with floor_mod itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tenstorrent/tt-forge-fe#517
Fixes tenstorrent/tt-forge-fe#710
TTNN directly supports remainder op. Since TVM doesn't have remainder op, aten::remainder is mapped to tvm's mod op and this will be mapped to Remainder op in Forge