Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erasing casting all floats on input and output to float32 #21

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

dgolubovicTT
Copy link
Contributor

Erasing these lines since they cast all tensors from any float to float32. This bug was hidden in pybuda because we hadn't used third return value of the method
translated_modules, translated_device_types, _ = generate_pybuda_module(module, pt_inputs, compiler_cfg, module.name, verify_cfg)

This third parameter is actualy translated_inputs, which had its data format changed by tvm in these lines.

@nvukobratTT do you maybe know why we did this? It doesn't seem desirable.

@nvukobratTT
Copy link
Contributor

@dgolubovicTT can't recall for sure. But I agree that this isn't a valid case as it'll tread all float types as float32 (e.g. float16).

@dgolubovicTT dgolubovicTT merged commit 038b6e9 into main Aug 23, 2024
7 checks passed
@nvukobratTT nvukobratTT deleted the dgolubovic/erase-casting-all-floats-to-float32 branch October 11, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants