Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete hstack and hslice patterns in pattern matching logic #37

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

dgolubovicTT
Copy link
Contributor

Delete hstack and hslice patterns in pattern matching logic since they won't be used anymore (Reshape aims to work on tt-metal without the need for decomposition)

…y won't be used anymore (Reshape aims to work on tt-metal without the need for decomposition)
Copy link
Contributor

@AleksKnezevic AleksKnezevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While metal has reshape and transpose ops, it also has much more performant (and I would imagine more general) split_heads (hslice) and concatonate_heads (hstack) ops. I would not remove these.

@nvukobratTT
Copy link
Contributor

While metal has reshape and transpose ops, it also has much more performant (and I would imagine more general) split_heads (hslice) and concatonate_heads (hstack) ops. I would not remove these.

Valid point, however, I think this is more suitable for fusing on the TTIR level.

Do you see the value of keeping these on frontends as well @AleksKnezevic? My concern is that this isn't standard FE op, and that there aren't many benefits of mapping these on TTIR. Rather, we should handle it during TTIR decomposition/fusing.

Let me know your thoughts :))

@AleksKnezevic
Copy link
Contributor

Yeah, I'm happy with moving these to TTIR level.

@dgolubovicTT dgolubovicTT merged commit c0e6573 into forge_track Oct 8, 2024
4 checks passed
@nvukobratTT nvukobratTT deleted the dgolubovic/delete-hslice-hstack-patterns branch October 11, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants