Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved test infrastructure. #100

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Improved test infrastructure. #100

merged 1 commit into from
Dec 19, 2024

Conversation

kmitrovicTT
Copy link
Contributor

@kmitrovicTT kmitrovicTT commented Dec 3, 2024 •
edited
Loading

  • Provided layer which uses jax to connect to various devices
  • Provided layer which uses jax to run payload on various devices
  • Provided infra which makes it easy to unit test either simple ops, or graphs or even full models
  • Fixed venv/activate script since it seemed to use a lot of unnecessary stuff (will send a separate PR to improve it further)

Fixes #80, #93.

@kmitrovicTT kmitrovicTT self-assigned this Dec 3, 2024
mrakitaTT
mrakitaTT reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@mrakitaTT mrakitaTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some thoughts in comments, let's talk more today. Lot of these things will become much clearer when we start adding first models, so I wouldn't rush with pushing in these changes yet.

src/common/api_impl.h Outdated Show resolved Hide resolved
tests/graphs/test_arbitrary_op_chain.py Outdated Show resolved Hide resolved
tests/graphs/test_arbitrary_op_chain.py Outdated Show resolved Hide resolved
tests/infra/device_connector.py Outdated Show resolved Hide resolved
tests/infra/device_runner.py Outdated Show resolved Hide resolved
tests/infra/module_tester.py Outdated Show resolved Hide resolved
tests/infra/test_module.py Outdated Show resolved Hide resolved
tests/models/test_simple_nn.py Outdated Show resolved Hide resolved
tests/models/test_simple_nn.py Outdated Show resolved Hide resolved
tests/models/test_simple_nn.py Outdated Show resolved Hide resolved
@kmitrovicTT kmitrovicTT force-pushed the kmitrovic/test_infra branch 2 times, most recently from 00918dc to c8ad5be Compare December 13, 2024 17:01
mrakitaTT
mrakitaTT reviewed Dec 17, 2024
View reviewed changes
tests/jax/ops/test_add.py Outdated Show resolved Hide resolved
tests/jax/models/test_simple_nn.py Outdated Show resolved Hide resolved
tests/jax/models/test_simple_nn.py Outdated Show resolved Hide resolved
tests/jax/models/test_simple_nn.py Outdated Show resolved Hide resolved
tests/infra/utils.py Outdated Show resolved Hide resolved
tests/infra/base_model_tester.py Outdated Show resolved Hide resolved
tests/infra/base_model_tester.py Outdated Show resolved Hide resolved
@kmitrovicTT kmitrovicTT force-pushed the kmitrovic/test_infra branch 9 times, most recently from 086ad7e to 4d23305 Compare December 18, 2024 16:48
@kmitrovicTT kmitrovicTT marked this pull request as ready for review December 18, 2024 16:53
mrakitaTT
mrakitaTT reviewed Dec 18, 2024
View reviewed changes
tests/infra/base_tester.py Show resolved Hide resolved
src/common/api_impl.h Outdated Show resolved Hide resolved
tests/infra/utils.py Outdated Show resolved Hide resolved
tests/jax/graphs/test_arbitrary_op_chain.py Outdated Show resolved Hide resolved
tests/jax/models/example_model/model.py Outdated Show resolved Hide resolved
tests/jax/models/flax_distil_bert_for_masked_lm/test_flax_distil_bert_for_masked_lm.py Outdated Show resolved Hide resolved
tests/infra/model_tester.py Outdated Show resolved Hide resolved
mrakitaTT
mrakitaTT approved these changes Dec 19, 2024
View reviewed changes
tests/jax/models/example_model/model.py Outdated Show resolved Hide resolved
@kmitrovicTT kmitrovicTT force-pushed the kmitrovic/test_infra branch 3 times, most recently from db95cf1 to 30fa90a Compare December 19, 2024 18:18
@kmitrovicTT
Improved test infrastructure.
16d97ce 
- Provided layer which uses jax to connect to various devices
- Provided layer which uses jax to run payload on various devices
- Provided infra which makes it easy to unit test either simple ops, or graphs or even full models

Fixes #80, #93.
@kmitrovicTT kmitrovicTT enabled auto-merge (squash) December 19, 2024 18:19
@kmitrovicTT kmitrovicTT merged commit 5d8a492 into main Dec 19, 2024
6 checks passed
@kmitrovicTT kmitrovicTT deleted the kmitrovic/test_infra branch December 19, 2024 18:42
@mrakitaTT mrakitaTT mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajakovljevicTT ajakovljevicTT ajakovljevicTT left review comments

@mrakitaTT mrakitaTT mrakitaTT approved these changes

@sgligorijevicTT sgligorijevicTT Awaiting requested review from sgligorijevicTT

Assignees

@kmitrovicTT kmitrovicTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more explicit generation of test tensors regarding devices in the test infrastructure
3 participants
@kmitrovicTT @ajakovljevicTT @mrakitaTT