Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding infrastructure for multichip tests #231

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ajakovljevicTT
Copy link
Contributor

Ticket

Part of issue #211

Problem description

Integrating new tester class, called MultichipTester, into our testing infrastructure intt-xla. It will receive the input and output shardings from the user, the function to be tested, and the golden function which will run on CPU, in a non-sharded mode. It runs the received data and compared the results.

@ajakovljevicTT ajakovljevicTT force-pushed the ajakovljevic/adding_multichip_tests branch 4 times, most recently from 60f1a95 to d2dcb1e Compare February 4, 2025 16:07
Copy link

github-actions bot commented Feb 4, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-XLA Tests599 ran431 passed168 skipped0 failed
TestResult
No test annotations available

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (9ee5247) to head (1863d25).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   77.82%   78.06%   +0.24%     
==========================================
  Files          21       21              
  Lines        1028     1044      +16     
==========================================
+ Hits          800      815      +15     
- Misses        228      229       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajakovljevicTT ajakovljevicTT force-pushed the ajakovljevic/adding_multichip_tests branch from 4c2f7ac to 0086d31 Compare February 5, 2025 07:24
Copy link
Contributor

@kmitrovicTT kmitrovicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of comments just organizational and naming-wise. Once that is resolved, I'll take another look.

tests/infra/multichip_workload.py Outdated Show resolved Hide resolved
tests/jax/multichip/manual/all_gather.py Outdated Show resolved Hide resolved
tests/jax/multichip/manual/unary_eltwise.py Outdated Show resolved Hide resolved
tests/jax/multichip/manual/all_gather.py Outdated Show resolved Hide resolved
tests/jax/multichip/manual/all_gather.py Show resolved Hide resolved
tests/infra/device_runner.py Outdated Show resolved Hide resolved
tests/infra/device_runner.py Outdated Show resolved Hide resolved
tests/infra/device_runner.py Outdated Show resolved Hide resolved
tests/infra/device_runner.py Show resolved Hide resolved
tests/infra/device_runner.py Outdated Show resolved Hide resolved
@ajakovljevicTT ajakovljevicTT force-pushed the ajakovljevic/adding_multichip_tests branch 2 times, most recently from 148c3ae to aaf46cf Compare February 6, 2025 09:45
tests/infra/multichip_tester.py Outdated Show resolved Hide resolved
tests/infra/multichip_tester.py Outdated Show resolved Hide resolved
tests/infra/multichip_tester.py Outdated Show resolved Hide resolved
tests/jax/multichip/manual/all_gather.py Show resolved Hide resolved
tests/infra/workload.py Outdated Show resolved Hide resolved
tests/infra/device_runner.py Show resolved Hide resolved
tests/infra/device_runner.py Outdated Show resolved Hide resolved
tests/infra/device_runner.py Outdated Show resolved Hide resolved
tests/infra/device_runner.py Outdated Show resolved Hide resolved
tests/infra/multichip_tester.py Outdated Show resolved Hide resolved
@ajakovljevicTT ajakovljevicTT force-pushed the ajakovljevic/adding_multichip_tests branch 2 times, most recently from 2dbb39b to ec6db0f Compare February 7, 2025 17:15
@ajakovljevicTT ajakovljevicTT force-pushed the ajakovljevic/adding_multichip_tests branch from ec6db0f to 1863d25 Compare February 7, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants