-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable, fix(main/odin): copy build instructions from odin repository #22012
base: master
Are you sure you want to change the base?
Conversation
How would one check that this have successfully build, before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit description must have specific structure.
I suppose it's fine to squash commits on merge |
Or should i rebase? And change all descriptions |
Can error like
be fixed using something like?
|
Unfortunately we do not provide lower versions of llvm in main repo, so in the case if you do not find a workaround for build errors the PR will be closed. |
Yeah, so those errors are basically the same as those I got when trying to compile locally.
Does this mean that all currently build packages use the llvm 19? |
Correct. |
My line of thinking was: I don't want to build llvm just for this, but a build server can do it. So if odin depends only on the libraries and not the headers, should we entertain such idea? |
The github of the odin-lang project is active. You can simply open issue about llvm-19 support. |
The changes seem to be pretty pasic. I'll merge a pr there and come back to pull it up here |
I have been able to successfully build odin using proot-distro and it ran just fine. So it seems like the issue has been fixed from the odin side. One possible problem is that odin requires libllvm versions (11-14, 17, 18), but current versoin is 19, will see if it'll cause problems.
(If it were still open)
Closes #10892