Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable, fix(main/odin): copy build instructions from odin repository #22012

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

0dminnimda
Copy link

@0dminnimda 0dminnimda commented Oct 29, 2024

I have been able to successfully build odin using proot-distro and it ran just fine. So it seems like the issue has been fixed from the odin side. One possible problem is that odin requires libllvm versions (11-14, 17, 18), but current versoin is 19, will see if it'll cause problems.

(If it were still open)
Closes #10892

@0dminnimda
Copy link
Author

How would one check that this have successfully build, before merging?

Copy link
Member

@twaik twaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit description must have specific structure.

@0dminnimda 0dminnimda changed the title Enable odin enable, fix(main/odin): copy build instructions from odin repository Oct 30, 2024
@0dminnimda
Copy link
Author

I suppose it's fine to squash commits on merge

@0dminnimda
Copy link
Author

Or should i rebase? And change all descriptions

@twaik twaik requested a review from finagolfin October 30, 2024 11:08
@0dminnimda
Copy link
Author

Can error like

llvm-config: error: missing: /home/builder/.termux-build/_cache/android-r27b-api-24-v1/lib/libLLVMMCA.a
llvm-config: error: missing: /home/builder/.termux-build/_cache/android-r27b-api-24-v1/lib/libLLVMX86TargetMCA.a

be fixed using something like?

_LLVM_MAJOR_VERSION=$(. $TERMUX_SCRIPTDIR/packages/libllvm/build.sh; echo $LLVM_MAJOR_VERSION)
_LLVM_MAJOR_VERSION_NEXT=$((_LLVM_MAJOR_VERSION + 1))
TERMUX_PKG_DEPENDS="libllvm (<< ${_LLVM_MAJOR_VERSION_NEXT}), ..."

@twaik
Copy link
Member

twaik commented Oct 31, 2024

Unfortunately we do not provide lower versions of llvm in main repo, so in the case if you do not find a workaround for build errors the PR will be closed.

@0dminnimda
Copy link
Author

Yeah, so those errors are basically the same as those I got when trying to compile locally.

Unfortunately we do not provide lower versions of llvm in main repo

Does this mean that all currently build packages use the llvm 19?

@twaik
Copy link
Member

twaik commented Oct 31, 2024

Correct.

@0dminnimda
Copy link
Author

My line of thinking was: I don't want to build llvm just for this, but a build server can do it. So if odin depends only on the libraries and not the headers, should we entertain such idea?
Of course I'll see if it could be fixed by a simple patch, but still.

@twaik
Copy link
Member

twaik commented Oct 31, 2024

The github of the odin-lang project is active. You can simply open issue about llvm-19 support.

@0dminnimda
Copy link
Author

The changes seem to be pretty pasic. I'll merge a pr there and come back to pull it up here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: odin package doesn't work properly
2 participants