test: add database connectivity test

[Soaib024]

Description

https://github.ibm.com/goldeneye/issues/issues/5207

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

• When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
• Merge by using "Squash and merge".

[Soaib024]

Table and rows created in postgresql instance

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[shemau]

Does the test work? After running the apply locally, I see the db_connection created and complete before the VPE creation even starts. How would a connection work over private when there is no VPE gateway? (I am not sure DNS resolution works until this is live, but I may be wrong). If it does work and routes over the private network, it means that a VPE is not required/adds no value in the example. Additionally, my expectation of CBR is that they are not active immediately and the validation runs immediately after the CBR is created, possibly before it is in effect. Is there some way to confirm CBR is live before testing that the connection will run?

[Soaib024]

Hi @shemau, I was occupied with some other work, so I couldn't look into this for a while.

Yes, as you rightly pointed out, db_creation has to wait for the creation of vpe. I was testing something different when I added depends_on module.postgresql_db instead of module.vpe in a later commit. I then missed reverting it back, but I have now made the required changes.

CBR appears to be working based on my limited testing. here in a different branch where Postgres is scoped to cbr-zone that allows traffic from vpc-1 only while all other infrastructure is deployed in a different vpc. As expected, this example fails after multiple retries of remote-exec where as in PR branch it executes successfully.

Additionally, I've added on_failure = fail to the remote-exec, which will throw an error explicitly in case any of the commands fail to execute.

[Soaib024]

/run pipeline

[Soaib024]

@daniel-butler-irl @ocofaigh @shemau @toddgiguere

As discussed in the deep dive session, I have separated the logic for VSI creation and added it into tests/resources. It still relies on null_resources for executing commands against the Postgres instance. However, since this is now part of tests/resources, I believe it should be acceptable, especially considering it's not intended for consumers. Please let me know if we should eliminate the use of null_resources and execute commands directly from the test itself. Additionally, I have made some changes in example/complete to make it work. Thank you.

Here are the SQL query logs

[Soaib024]

/run pipeline

[Soaib024]

/run pipeline

[Soaib024]

[Soaib024]

Upgrade test is expected to fail, as this PR modifies default ACL rules created by vpc module and also security-group for postgresql will be created using module instead of resource block in example

there isn't any changes in root module

[Soaib024]

/run pipeline