Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Modified the diagram #251

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

docs: Modified the diagram #251

wants to merge 5 commits into from

Conversation

arya-girish-k
Copy link

Description

Modified the diagram deployable-architecture-observability-instances .
#12033

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k
Copy link
Author

/run pipeline

@arya-girish-k
Copy link
Author

/run pipeline

@arya-girish-k
Copy link
Author

/run pipeline

@iamar7 iamar7 linked an issue Feb 3, 2025 that may be closed by this pull request
Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrow is missing in the existing event notification instance. Also the existing kms arrow is pointing to root key rather than the existing kms instance

Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line from Cloud logs to the buckets has an extension which needs to be removed

@arya-girish-k
Copy link
Author

/run pipeline

@arya-girish-k
Copy link
Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Diagram Detail for Routers
2 participants