Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use fixed versions for ol, ol-util and react-styleguidist #3363

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

annarieger
Copy link
Member

The mentioned dependencies can be currently not updated and will be pinned to fixed versions.

  • react-styleguidist requires react >=18
  • ol-util requires ol >=7.4
  • ol update breaks the test due to changed mechanism of pointer event handling (compare test: use jest-runner-electron #3142)

Please review @terrestris/devs

Description

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@annarieger annarieger changed the title feat: Use fixes versions for ol, ol-util and react-styleguidist feat: Use fixed versions for ol, ol-util and react-styleguidist Jun 26, 2023
@annarieger annarieger merged commit bff2e2f into main Jun 26, 2023
@annarieger annarieger deleted the pin-ol branch June 26, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants