Fix occasional perma loading on explore page #627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the explore page, if you click on a course and press back + scroll down quickly, occasionally it will get permanently stuck in a loading state. (I can reproduce this quite easily on prod)
I think this happens because there's a race condition between two network requests, one for fetching page 1 and the other for fetching page 2, which somehow leads to
courses
being set toundefined
after they resolve?I tried to fix this by just falling back to the batch's courses instead of using the null chaining operator.
As far as I can tell from local testing with network throttling, it's fixed