Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Apache Kafka (KRaft) builder (#1347) #1348

Conversation

IbrayevRamil
Copy link

What does this PR do?

Adds Apache Kafka (KRaft) container builder

Why is it important?

Current Kafka builder doesn't support it

Related issues

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit e0c0dad
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/67988e8d56c1ad00083c8c28
😎 Deploy Preview https://deploy-preview-1348--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
ilario-pierbattista Ilario Pierbattista
@SukharevAndrey
Copy link

SukharevAndrey commented Jan 27, 2025

What a coincedence. The same thought came to me last week and I took different approach in #1353.
The difference:

  1. Supports for KRaft in Confluent image too
  2. Throws an error if KRaft is not supported in provided image
  3. Does not require another class to use. All happens in the same class without breaking backward compatibility.
  4. Makes the project nullable.
  5. Tests different setups.

Verified

This commit was signed with the committer’s verified signature.
ilario-pierbattista Ilario Pierbattista
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IbrayevRamil, do you have any feedback on @SukharevAndrey's comment? Can we please consolidate both PRs?

@IbrayevRamil
Copy link
Author

IbrayevRamil commented Feb 18, 2025

@IbrayevRamil, do you have any feedback on @SukharevAndrey's comment? Can we please consolidate both PRs?

His approach is much flexible and better all in all, so I would stick with it. Mine is just a hot fix :)
I will review his PR soon in more details and leave some comments if any

@HofmeisterAn
Copy link
Collaborator

HofmeisterAn commented Feb 18, 2025

@IbrayevRamil, do you have any feedback on @SukharevAndrey's comment? Can we please consolidate both PRs?

His approach is much flexible and better all in all, so I would stick with it. Mine is just a hot fix :) I will review his PR soon in more details and leave some comments if any

Thanks for the quick response. I will close this PR, and we continue working on: #1353. Still thanks for your efforts and contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add Apache Kafka Test Container to Kafka module
4 participants