-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Apache Kafka (KRaft) builder (#1347) #1348
feat: Add Apache Kafka (KRaft) builder (#1347) #1348
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What a coincedence. The same thought came to me last week and I took different approach in #1353.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IbrayevRamil, do you have any feedback on @SukharevAndrey's comment? Can we please consolidate both PRs?
His approach is much flexible and better all in all, so I would stick with it. Mine is just a hot fix :) |
Thanks for the quick response. I will close this PR, and we continue working on: #1353. Still thanks for your efforts and contribution. |
What does this PR do?
Adds Apache Kafka (KRaft) container builder
Why is it important?
Current Kafka builder doesn't support it
Related issues