Add Azure Service Bus Emulator container to Azure module #9795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implements new Service Bus Container - Adds new test case for Service Bus - Updates the Azure documentation Signed-off-by: Esta Nagy <[email protected]>
eddumelendez
requested changes
Jan 16, 2025
Comment on lines
51
to
58
| public AzureServiceBusEmulatorContainer emulator = new AzureServiceBusEmulatorContainer( | ||
| DockerImageName.parse("mcr.microsoft.com/azure-messaging/servicebus-emulator:1.0.1"), | ||
| mssqlServerContainer | ||
| ) | ||
| .acceptLicense() | ||
| .withConfig(MountableFile.forClasspathResource("/service-bus-config.json")) | ||
| .withNetwork(network); | ||
|
|
There was a problem hiding this comment.
Let's keep the constructor only accepting the image as a String or DockerImageName. Rather we can declare dependsOn via de API.
Suggested change
| public AzureServiceBusEmulatorContainer emulator = new AzureServiceBusEmulatorContainer( | |
| DockerImageName.parse("mcr.microsoft.com/azure-messaging/servicebus-emulator:1.0.1"), | |
| mssqlServerContainer | |
| ) | |
| .acceptLicense() | |
| .withConfig(MountableFile.forClasspathResource("/service-bus-config.json")) | |
| .withNetwork(network); | |
| public AzureServiceBusEmulatorContainer emulator = new AzureServiceBusEmulatorContainer( | |
| DockerImageName.parse("mcr.microsoft.com/azure-messaging/servicebus-emulator:1.0.1") | |
| ) | |
| .acceptLicense() | |
| .withConfig(MountableFile.forClasspathResource("/service-bus-config.json")) | |
| .withNetwork(network) | |
| .dependsOn(mssqlServerContainer); |
There was a problem hiding this comment.
I have created a new withMsSqlServerContainer(MSSQLServerContainer) method instead because I needed to get the password and the network alias for the env setup in configure(). For this reason the dependency on the module remained as-is too. Is this acceptable?
modules/azure/src/test/java/org/testcontainers/azure/AzureServiceBusEmulatorContainerTest.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzureServiceBusEmulatorContainerTest.java
Outdated
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzureServiceBusEmulatorContainerTest.java
Show resolved
Hide resolved
modules/azure/src/test/java/org/testcontainers/azure/AzureServiceBusEmulatorContainerTest.java
Outdated
Show resolved
Hide resolved
| @@ -2,6 +2,7 @@ description = "Testcontainers :: Azure" | |||
|
|
|||
| dependencies { | |||
| api project(':testcontainers') | |||
| api project(':mssqlserver') | |||
There was a problem hiding this comment.
documentation must mention dependency on this module
Suggested change
| api project(':mssqlserver') | |
| testImplementation project(':mssqlserver') |
There was a problem hiding this comment.
Left as-is due to: #9795 (comment)
- Fix code review findings Signed-off-by: Esta Nagy <[email protected]>
- Fix typo Signed-off-by: Esta Nagy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #9607 (comment)