chore: update witness.yml with workingdir input #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriscoleman
force-pushed
the
workingdir-input
branch
4 times, most recently
from
306b71b to
e229e82
Compare
|
@georgesdugue and I found more issues with this. Because of the conditional on working through some more fixes |
kriscoleman
force-pushed
the
workingdir-input
branch
3 times, most recently
from
c3d9089 to
6bea697
Compare
Added a new 'workingdir' input to the GitHub Actions workflow. This allows for specifying the working directory when running commands. The changes include: - Added 'workingdir' as an optional input in the workflow_call section. - Updated testifysec/witness-run-action usage to include 'workingdir'. - Set 'working-directory' for run commands when pull_request is true. This enhancement provides more flexibility in configuring workflows, especially when dealing with projects that have complex structures or require specific execution contexts.
kriscoleman
force-pushed
the
workingdir-input
branch
from
c237f2e to
d5390fb
Compare
|
worked through the issues
|
jkjell
reviewed
Jan 15, 2025
kriscoleman
commented
Jan 16, 2025
jkjell
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes to get workingdir working with john's reusable workflow branch
@jkjell we have this and one other PR on your reusable workflow branch. Total that's 3 prs not merged to main that we're using in one place or another. We should get those all merged before we lose track.