fix(rerender): Do not mount component again on rerender #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afontcu
commented
Jan 8, 2021
|
|
||
| wrapper = mountComponent(TestComponent, props) | ||
| }, | ||
| rerender: props => wrapper.setProps(props), |
There was a problem hiding this comment.
This is mostly it. Other changes are there because we don't need a wrapper variable (and a mountComponent function) anymore.
Codecov Report
@@ Coverage Diff @@
## next #199 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 91 84 -7
Branches 30 29 -1
=========================================
- Hits 91 84 -7
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 6.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197 and #198