Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JCommander to 1.83 #3123

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

adessaigne
Copy link
Contributor

Fixes #3122 .

Did you remember to?

  • Add test case(s): not needed for this update
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply: not needed for this update

Copy link

coderabbitai bot commented May 7, 2024

Walkthrough

The recent update primarily involves upgrading the JCommander library from version 1.82 to 1.83 in the TestNG framework. This change includes an update to the groupId due to the library's migration from com.beust to org.jcommander.

Changes

File Path Change Summary
CHANGES.txt Added a fix for updating JCommander to version 1.83.
.../testng-core-build.gradle.kts Updated JCommander dependency from com.beust:1.82 to org.jcommander:1.83.

Assessment against linked issues

Objective Addressed Explanation
Update TestNG to use JCommander 1.83 (#3122)

Possibly related issues

  • Use org.testng as groupid testng-remote#143: This issue involves updating the groupId for dependencies. Although it specifically mentions org.testng, the practice of updating groupId as seen with JCommander suggests a possible relevance.

🐇🎉
In the meadow of code, under the sky so blue,
A tiny change rolls out, oh look, it's JCommander 1.83, it's true!
From com.beust to org.jcommander, a hop so bold,
Ensuring all dependencies, in TestNG, are gold.
Cheers to the devs, with carrots so sweet,
For making our software, ever so neat! 🥕🎶
🐇🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 067b35f and 551ac8f.
Files selected for processing (2)
  • CHANGES.txt (1 hunks)
  • testng-core/testng-core-build.gradle.kts (1 hunks)
Files skipped from review due to trivial changes (2)
  • CHANGES.txt
  • testng-core/testng-core-build.gradle.kts

@krmahadevan krmahadevan merged commit 24954fa into testng-team:master May 7, 2024
8 of 9 checks passed
@adessaigne adessaigne deleted the jcommander branch May 7, 2024 16:13
@adessaigne
Copy link
Contributor Author

Thank you for merging it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JCommander to 1.83
3 participants