-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Custom Settings to Apps Endpoint of Portal API #1004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swainn
force-pushed
the
api-custom-settings
branch
from
January 8, 2024 23:37
6894544
to
3a46d7c
Compare
shawncrawley
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took a bit longer to get to this, but I've looked it over and approve!
format and lint
swainn
force-pushed
the
api-custom-settings
branch
from
January 11, 2024 18:44
e5dde2d
to
896c326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the custom settings to the object that is returned when calling the
apps
endpoint of the Tethys Portal REST API. This makes the custom settings available to apps with the React frontend, which uses the REST API to get info about the app.request
user is authenticated. Otherwise, the endpoint returns only the basic metadata about the app.CustomSettingsBase
model:include_in_api
. The setting is included in the API response ifinclude_in_api
isTrue
. Defaults toFalse
.Example of object returned with custom settings:
Also in this PR: