Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Handlers/Jobs Table #1082

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Async Handlers/Jobs Table #1082

merged 7 commits into from
Sep 6, 2024

Conversation

sdc50
Copy link
Member

@sdc50 sdc50 commented Aug 19, 2024

Description

Adds async support for bokeh handlers and for the jobs table endpoints
Fixes a security issue with the jobs table and enhances the formatting of logs

Changes Made to Code:

This primarily:

  • modifies decorators related to handlers to support async hander functions and
  • Modifies the jobs table gizmo views to be asynchronous and support asynchronous calls on TethysJob objects

It also:

  • Modifies the PR template so that the Quality Checks checkboxes are formatted correctly
  • Minor tweak to the react scaffold to support .jsx files
  • Adds an OAUTH2_PROVIDER_URL_NAMESPACE setting to customize where the OAuth2 Provider URLs are mounted and changes the default to o/
  • Adds some basic docs about the OAuth2 Provider settings
  • Puts to log content for the jobs tab in a pre tag to preserve formatting
  • add tests to cover some missing cases for the map_view basemaps

Related

Quality Checks

  • New code is 100% tested
  • Code has been formated
  • Code has been linted
  • Docstrings for new methods have been added

@coveralls
Copy link

coveralls commented Aug 19, 2024

Coverage Status

coverage: 100.0% (+0.06%) from 99.936%
when pulling 2c816e7 on basic_async_support
into fbf295d on main.

@sdc50 sdc50 marked this pull request as ready for review August 19, 2024 21:31
@sdc50 sdc50 marked this pull request as draft August 22, 2024 15:26
@sdc50
Copy link
Member Author

sdc50 commented Aug 22, 2024

I still need to test some database async access.

tethys_gizmos/views/gizmos/jobs_table.py Outdated Show resolved Hide resolved
tethys_gizmos/views/gizmos/jobs_table.py Outdated Show resolved Hide resolved
tethys_gizmos/views/gizmos/jobs_table.py Show resolved Hide resolved
@swainn swainn added this to the Version 4.3 milestone Aug 24, 2024
@sdc50 sdc50 marked this pull request as ready for review August 30, 2024 19:50
Support OAUTH2_PROVIDER_URL_NAMESPACE setting
Copy link
Contributor

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@swainn swainn merged commit c7b468f into main Sep 6, 2024
42 checks passed
@swainn swainn deleted the basic_async_support branch September 6, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants