UE-385 :: 1 time review of mui rte upstream prs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hararia
deleted the
ue-feature/385-1-time-review-of-mui-rte-upstream-PRs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UE-385
Of the 8 PRs listed in the ticket, only Add an example of Material UI TextField integration by steurt · Pull Request #131 · niuware/mui-rte didn't make it in. It was very buggy. I got through two or three bugs and more kept presenting.
Additionally, the implementation of Added multilevel Lists by DMOEdetc · Pull Request #262 · niuware/mui-rte is limited. The logic in this PR in minimal, and styling is needed to render the multilevel (tabbed) lists correctly. draft-js (which this is built on) provides styling up to lists of depth 4, and I basically copied that styling over. I tried to find a way to programmatically apply these styles as needed, but couldn't find a reliable way. It's redundant, and ultimately limited, but we can always add more styling for additional list depth.