Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine CD for gh-pages #59

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Refine CD for gh-pages #59

merged 1 commit into from
Nov 18, 2024

Conversation

ATQlove
Copy link
Contributor

@ATQlove ATQlove commented Nov 18, 2024

Use explicit workflow instead of action from the external repo to do Continuous Deployment of HTML documents.
Also fix the issue that forget to carry over the index.html file.

@mgubi
Copy link
Contributor

mgubi commented Nov 18, 2024

Is it sure to put the git token in the git clone request? Also, if you found the solution on the internet, would be nice to put a comment with a pointer where this particular pattern has been mentioned. So that during the review phase people can check the sources. And would be also nice to have some more comment to explain what is going on.

@mgubi mgubi merged commit 2d8ca9a into texmacs:main Nov 18, 2024
1 check failed
@mgubi
Copy link
Contributor

mgubi commented Nov 18, 2024

The action is still not quite ok. When we generate the html pages we want both to commit them to the main branch and also to create an appropriate gh-pages branch so that the pages can be published online. Currently the action just create new html pages in the gh-pages branch, without committing them to the main branch.

@mgubi
Copy link
Contributor

mgubi commented Nov 18, 2024

I've fixed the action in the repository. Seems to work well now. Thanks! (please anyway, add some comments on the various parts of the action, for future reference). Also, the action take long time to run, especially because it downloads a lot of packages (including texlive!). Would be nice to optimise this.

@ATQlove
Copy link
Contributor Author

ATQlove commented Nov 19, 2024

texlive

Thank you for addressing the issue! I appreciate your efforts. Also, I apologize for the poorly written comments before and will ensure to add meaningful ones in the future.

And I think right now we can delete this part from cd-convert-debian-bookworm.yml (I want to do this before this PR is merging, but since we are in different time zones, I didn’t see the reply in time)

pull_request:
    branches:
      - main

Removing this section would prevent the CD pipeline from being triggered when a PR is created. This behavior seems more reasonable since we primarily want to trigger CD only when changes are merged or pushed to the repository. With this adjustment, the longer runtime would be more acceptable given the infrequency of these events.

@mgubi
Copy link
Contributor

mgubi commented Nov 20, 2024

I've now created a container with TeXmacs pre-installed so that the workflow now runs more rapidly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants